-
Notifications
You must be signed in to change notification settings - Fork 63
Checkpoints introduction for version changes #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduce get_delta method with caching - introduce delta contrller
- added tests for pull and checkpoints
- accept numbers in endpoint - consider to store diff instead of diffs in db
Pull Request Test Coverage Report for Build 18915751036Details
💛 - Coveralls |
varmar05
requested changes
Oct 10, 2025
- rename table to project version delta with column changes - rename classes - add get_delta_changes to project instance (nice) - fix migration to int
- update new table schema for project version delta - add tests and upgrade existing to handle order of diffs
- handle delete project cleanup of delta checkpoints
varmar05
requested changes
Oct 29, 2025
- update reponse to items: [] - make it more clear with changes logic (?) - @varmar05
varmar05
reviewed
Oct 30, 2025
varmar05
approved these changes
Oct 30, 2025
Collaborator
|
It's quite heavy logic but looks great, good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/MerginMaps/server-private/issues/3014
We are introducing new table for storing chckpoints (project_version_change), where rank and delta json for current version is stored. If version are in logarithms logic with base=4, then store higher level checkpoints if needed.
Structure for delta json: List[DeltaData]. If there is not diff, diff key is not provided in result.
[ { "diff": "Survey_points.gpkg-diff-14ee7fe7-366a-4ba8-85f3-f15c38242d93", "path": "Survey_points.gpkg", "size": 98304, "change": "update_diff", "version": 25, "checksum": "12b26ef4ed11e4fb411baf40402fedf26696f830" } ]Delta creation logic
Migration
Migrate file history and file diffs to merged delta in project_version_change table.